Conversation
…e class Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
…standard2.0 Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
==========================================
+ Coverage 87.35% 87.48% +0.12%
==========================================
Files 47 47
Lines 1827 1917 +90
Branches 190 216 +26
==========================================
+ Hits 1596 1677 +81
- Misses 188 191 +3
- Partials 43 49 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
askpt
requested review from
arttonoyan,
beeme1mr,
kinyoklion,
kylejuliandev and
toddbaert
askpt
commented
Jul 14, 2025
| <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="$(MicrosoftExtensionsVersion)" /> | ||
| <PackageVersion Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="$(MicrosoftExtensionsVersion)" /> | ||
| <PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="$(MicrosoftExtensionsVersion)" /> | ||
| <PackageVersion Include="Microsoft.Bcl.HashCode" Version="1.1.1" /> |
Member
Author
There was a problem hiding this comment.
Great question. It is used to generate the HashCode for the IEquatable override. Check the documentation here: https://learn.microsoft.com/en-us/dotnet/api/system.hashcode?view=net-9.0
kylejuliandev
approved these changes
Jul 14, 2025
beeme1mr
approved these changes
Jul 14, 2025
This was referenced Jul 31, 2025
Closed
This was referenced Nov 26, 2025
This was referenced Jan 22, 2026
Closed
Bump the nuget-production-dependencies group with 17 updates
PraveenKumarDova/opentelemetry-demo#113
Closed
Bump the nuget-production-dependencies group with 16 updates
dastagiridev-tech/opentelemetry-demo#85
Closed
Bump the nuget-production-dependencies group with 16 updates
laurentpf5/opentelemetry-nginx-demo#170
Closed
This was referenced Feb 3, 2026
Closed
Closed
Closed
Closed
Open
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: André Silva 2493377+askpt@users.noreply.github.com
This PR
This pull request introduces enhancements to the
Valueclass in theOpenFeature.Modelnamespace, ensuring better equality handling, and updates dependencies to includeMicrosoft.Bcl.HashCode. The most significant changes include implementing equality comparison forValue, adding hash code generation, and updating project files to include the new dependency.Enhancements to
Valueclass:src/OpenFeature/Model/Value.cs: TheValueclass now implementsIEquatable<Value>and includes methods for equality comparison (Equals,==,!=), hash code generation (GetHashCode), and internal helpers for comparing complex types like structures and lists. This ensures more robust and consistent equality checks. [1] [2]Dependency updates:
Directory.Packages.props: AddedMicrosoft.Bcl.HashCodeas a dependency for hash code generation. Other package references were reformatted for consistency.src/OpenFeature/OpenFeature.csproj: IncludedMicrosoft.Bcl.HashCodefor specific target frameworks (net462andnetstandard2.0).Notes
This implementation is necessary for the comparison in the MultiProvider. See: #488 (comment)